Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for March servicing #2050

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Update for March servicing #2050

merged 1 commit into from
Mar 20, 2023

Conversation

richlander
Copy link
Member

@richlander richlander commented Mar 15, 2023

Happy Pi day!

Microsoft Reviewers: Open in CodeFlow

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joperezr
Copy link
Member

Seems like the Button.Tests unit tests (cc: @raffaeler ) are failing on this PR, but not sure if they are just flaky or something here is affecting it which I doubt. I'll re-run to double-check.

@raffaeler
Copy link
Contributor

@joperezr I opened all the logs but I only see:

  • Platform 'esp32:esp32' not found: platform not installed
  • ##[error]Artifact BuildPackages already exists for build 89568.

Could you please give me the link to the failed test?

@joperezr
Copy link
Member

Yeah, this is because if the unit test project that fails doesn't have the UI thread it won't log the errors because the runner has had a bug for a long time where it uses Console.WriteLine as opposed to Log.WriteLine which means that in a multi-threaded build, you would likely miss the errors getting printed. Seems like this is failing consistently on Windows, we should try to pull the changes on this branch locally and run those tests and we should be able to repro

@raffaeler
Copy link
Contributor

Got it, but where did you see the button tests failing?
Can you tell me at least which one was failing?

@pgrawehr
Copy link
Contributor

/azp run dotnet.iot

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krwq
Copy link
Member

krwq commented Mar 20, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joperezr
Copy link
Member

Merging since the Arduino leg has now been disabled and therefore won't re-run.

@joperezr joperezr merged commit 3dc1e30 into main Mar 20, 2023
@richlander richlander deleted the richlander-patch-2 branch March 20, 2023 22:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants