Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #2051

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Fix build #2051

merged 5 commits into from
Mar 17, 2023

Conversation

krwq
Copy link
Member

@krwq krwq commented Mar 16, 2023 •
edited
Loading

Fix build:

  • Run:
build -pack /p:ApiCompatGenerateSuppressionFile=true
  • change pipelines configuration (some settings prevented helix from running)
  • attempt to fix PWM tests
Microsoft Reviewers: Open in CodeFlow

@krwq krwq closed this Mar 17, 2023
@krwq krwq reopened this Mar 17, 2023
@krwq krwq force-pushed the update-compat-suppressions branch from f699689 to b022903 Compare March 17, 2023 10:06
@Ellerbach
Copy link
Member

We should be able to change programmatically the pin behavior:

iot/src/devices/Board/RaspberryPiBoard.cs

Line 449 in 82a5abd

protected override void ActivatePinMode(int pinNumber, PinUsage usage)

So something like:

RaspberryPiBoard board = new();
board.ActivatePinMode(12, PinUsage.Pwm);

should set the PWM mode

@krwq krwq changed the title Update CompatibilitySuppressions.xml Fix build Mar 17, 2023
This was referenced Mar 17, 2023
Open
Closed
@krwq krwq merged commit 6e238a0 into dotnet:main Mar 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ellerbach Ellerbach Ellerbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krwq @Ellerbach