change Mfrc522.ReselectTarget to use WUPA instead of REQA

[jdbruner]

Mfrc522.ReselectTarget is used to reselect a card, notably after an error occurs. It does a HALT and then uses IsCardPresent to reconnect with the card, which eventually uses REQA. However, according to ISO 14443-3, if the card successfully executes a HALT then it will not respond to a REQA; instead, the PCD is required to use WUPA (wakeup). As a result, if ReselectTarget is called when the card is not in an error state, the card is non-responsive until it is taken out of range of the transceiver so that a completely new session can begin.

This PR adds an optional reselect parameter (default false) to IsCardPresent and also adds an optional commandCode parameter to the private function PiccRequestA to specify which command to send to the card. ReselectTarget uses this to request reselection with WUPA.

With this change, it is now possible to halt and wake up cards. Calling ReselectTarget (typically using something like MifareCard.ReselectCard) on a card that is not in error state no longer puts the card in a non-responsive state.

Pn532.ReselectTarget already uses WUPA., and Pn5180.ReselectTarget is not implemented for Type A.

Microsoft Reviewers: Open in CodeFlow

[Ellerbach]

Looks good as well. Thanks for the heavy testing here.

[jdbruner]

What do I need to do in order to resolve the API compatibility errors (because of the new optional parameter to IsCardPresent)?

[joperezr]

NIT: In order to not be binary breaking, any reason why we shouldn't just add new overloads as opposed to using default parameters?

[joperezr]

What do I need to do in order to resolve the API compatibility errors

You just rerun the pack command locally and pass in the property /p:ApiCompatGenerateSuppressionFile=true so that the errors get baselined. I ran that locally so I'll just take the liberty to push those changes here. That said, I did ask the question above to consider just adding a new overload instead so as to not be binary breaking. @jdbruner if you end up deciding to do that, please just revert the change that I'm about to push as it won't be needed any longer.

[jdbruner]

Thanks. I thought about creating an overload, but from a documentation perspective I think it is easier to understand the optional argument than the overloaded alternatives.

[krwq]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[joperezr]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).