Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ReselectAfterError property to MifareCard and UltralightCard #2062

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

jdbruner
Copy link
Contributor

@jdbruner jdbruner commented Mar 29, 2023

Add a new property ReselectAfterError to MifareCard and UltralightCard. When true, if an error occurs when performing an NFC transceive operation (RunMifareCardCommand or RunUltralightCommand, respectively), call ReselectCard to re-select the card. If it is false, the caller is responsible for reselecting the card.

Update the examples in the README files.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio label Mar 29, 2023
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for all those fixes and improvements!

Console.WriteLine($"Tg: {decrypted.TargetNumber}, ATQA: {decrypted.Atqa} SAK: {decrypted.Sak}, NFCID: {BitConverter.ToString(decrypted.NfcId)}");
if (decrypted.Ats is object)
Console.Write($"Tg: {decrypted.TargetNumber}, ATQA: {decrypted.Atqa} SAK: {decrypted.Sak}, NFCID: {BitConverter.ToString(decrypted.NfcId)}");
if (decrypted.Ats is object) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with the rest

Suggested change
if (decrypted.Ats is object) {
if (decrypted.Ats is object)
{

Copy link
Contributor Author

@jdbruner jdbruner Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed.

Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com>
@joperezr
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joperezr joperezr added this to the v3.0.0 milestone Apr 13, 2023
@Ellerbach Ellerbach merged commit 85d3d79 into dotnet:main Apr 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants