-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new display device - Pimoroni Four letter phat display #2118
Conversation
@dotnet-policy-service agree |
@dotnet-policy-service agree
… On 6 Aug 2023, at 17:55, dotnet-policy-service[bot] ***@***.***> wrote:
@dotnet-policy-service agree
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's a great start and a great addition. I have added some first comments and suggestions.
src/devices/Display/samples/Large4Digit14SegmentDisplay/Program.cs
Outdated
Show resolved
Hide resolved
/azp run dotnet.iot |
Azure Pipelines successfully started running 1 pipeline(s). |
Fixed issues with Markdown on windows build
- Letter B Fixed - Console output removed - Changed accessibility for unnecessary public write method - Added '.' do degrees display in sample - removed no longer require IFourteenSegmentDisplay interface - intenalised FontHelper.cs (added WriteHex and WriteChar to display. TO-DO: - Fix more chars in Font14.cs - Fix broken WirteChar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks really good all up. Great reuse of the existing elements and patterns.
Thanks for all your comments so far. V helpful. |
/azp run dotnet.iot |
Azure Pipelines successfully started running 1 pipeline(s). |
Fix broken link
MD markup creates too large an image. Reverted to html...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
/azp run dotnet.iot |
Azure Pipelines successfully started running 1 pipeline(s). |
Merging ad all approved and all green! Thanks again for the contribution @t1mr0dg3r5 |
Code based on the existing 7 segment display utilising the HT16K33 chipset.
https://shop.pimoroni.com/products/four-letter-phat?variant=39256047178
Microsoft Reviewers: Open in CodeFlow