Bind to explicit major version of libgpiod - Try 2 #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-System.Device.Gpio
raffaeler
approved these changes
Aug 17, 2023
Ellerbach
reviewed
Aug 18, 2023
| static Libgpiod() | ||
| { | ||
| InvalidHandleValue = new IntPtr(-1); | ||
| #if NET6_0_OR_GREATER |
There was a problem hiding this comment.
just to double check; with any other version, we will have the existing behavior, right? In that case, looks all good to me!
There was a problem hiding this comment.
The following line is what always existed in current versions:
private const string LibgpiodLibrary = "libgpiod";
This line of code will now used only for netstandard (which we basically use only for Mono on Linux).
pgrawehr
approved these changes
Aug 18, 2023
|
nice job figuring this out! |
Closed
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1070
This is essentially trying to use version 2.0 of libgpiod to remove the need of installing the -dev package, and adds some logic in the case that version 2.0 is not found so that it can instead look for version 1.6. This was inspired by @Tragetaschen comment on the first attempt PR, as well as following precedence to a very similar change that was made in dotnet/runtime solving a very similar situation.
cc: @pgrawehr @raffaeler @Ellerbach
Microsoft Reviewers: Open in CodeFlow