Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RaspberryBoardInfo.cs for pi400 Rev 1.1 #2124

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Update RaspberryBoardInfo.cs for pi400 Rev 1.1 #2124

merged 2 commits into from
Aug 31, 2023

Conversation

stevetms
Copy link
Contributor

@stevetms stevetms commented Aug 27, 2023 •
edited by ghost
Loading

pi400 Rev 1.1 Revision is 0x3131

Microsoft Reviewers: Open in CodeFlow

@stevetms
Update RaspberryBoardInfo.cs for pi400 Rev 1.1
4f97e98 
pi400 Rev 1.1 Revision is 0x3131
@ghost ghost added the area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins label Aug 27, 2023
@stevetms stevetms closed this Aug 27, 2023
@pgrawehr
Copy link
Contributor

@stevetms What's the reason you closed this?

@stevetms stevetms reopened this Aug 29, 2023
@stevetms
Copy link
Contributor Author

My mistake operation for close

Ellerbach
Ellerbach approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Ellerbach
Copy link
Member

/azp run dotnet.iot

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stevetms stevetms closed this Aug 30, 2023
@stevetms stevetms reopened this Aug 30, 2023
@Ellerbach
Copy link
Member

Note for the triage: the build on Mac Debug is failing most likely related to the flaky tests on buttons. It is not related to this PR. And it's good to go from my perspective.

@raffaeler raffaeler mentioned this pull request Aug 30, 2023
Closed
@raffaeler
Copy link
Contributor

raffaeler commented Aug 30, 2023 •
edited
Loading

Note for the triage: the build on Mac Debug is failing most likely related to the flaky tests on buttons. It is not related to this PR. And it's good to go from my perspective.

FYI I just opened a PR to fix the issue
The new failure is just due to the timeout preventing the test to hang forever
I also extended the fix to another test that use a secondary thread.
I hope to have resolved the issue now

@raffaeler
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krwq
Copy link
Member

krwq commented Aug 31, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krwq krwq merged commit 47e40bc into dotnet:main Aug 31, 2023
9 checks passed
@stevetms stevetms deleted the patch-1 branch September 1, 2023 03:34
@pgrawehr pgrawehr added this to the v3.1.0 milestone Nov 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raffaeler raffaeler raffaeler approved these changes

@Ellerbach Ellerbach Ellerbach approved these changes

Assignees
No one assigned
Labels
area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@stevetms @pgrawehr @Ellerbach @raffaeler @krwq