Allow creation of duplicate device addresses for the Tca9548A. #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After all, that's what it's for.
We absolutely need some default simulation implementation for the main hardware layes (I2C, SPI, GPIO), otherwise testing becomes a nightmare, because the mocks have always to be created manually.
boondoggler74
approved these changes
Oct 13, 2023
Ellerbach
approved these changes
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2141
This should fix the use case where multiple devices with the same address are used with a TCA9548A. That's one of the main use cases for this device, after all. I have no such device, so the code is only tested using unit testing.
Microsoft Reviewers: Open in CodeFlow