Updates and fixes to NMEA and Seatalk libraries #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intensive real-world testing has been done on these.
dotnet-policy-service
bot
added
the
area-device-bindings
Ellerbach
approved these changes
Sep 12, 2024
| if (unicast.Address.AddressFamily == AddressFamily.InterNetwork) | ||
| { | ||
| byte[] ipBytes = unicast.Address.GetAddressBytes(); | ||
| // A virtual address usually looks like a router address, that means it's last part is .1 |
There was a problem hiding this comment.
my router is not on a .1 address, not super sure you can use this trick
There was a problem hiding this comment.
This is a bit of trial-and-error code. It tries to find the main ethernet adapter of the local computer. The assumption here is that if an adapter has .1 then it's not the one connecting to the internet, but rather one that is used e.g. as a virtual adapter for docker/VM services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few new messages to the NMEA0183 and Setalak protocols. Includes some new position and angle helper methods.
Microsoft Reviewers: Open in CodeFlow