Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[param-name-importer] Bump to Microsoft.Xml.SgmlReader 1.8.16 (#656)
Microsoft.Xml.SgmlReader 1.8.16 supports .NET Standard 2.0 There is an issue with the new version in that the `lib/netcoreapp3.1` directory contains both `SgmlReader.exe` and `SgmlReaderDll.dll` and the `netcoreapp3.1` version of `param-name-importer` tries to consume the `.exe` file. Work around this by using `@(PackageReference)` to download the NuGet but not reference any assembly. Then we add a `@(Reference)` to the correct `.dll` and use it. (We use the `netstandard2.0` version because both frameworks can use it; `netcoreapp3.1` shouldn't even exist in the package.) Fix a warning by changing the `@(System.IO.Compression)` for `System.IO.Compression` to be conditional on building for (desktop) .NET Framework, not .NET Core Warning MSB3243: No way to resolve conflict between "System.IO.Compression, Version=4.2.2.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" and "System.IO.Compression". Choosing "System.IO.Compression, Version=4.2.2.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" arbitrarily.
- Loading branch information