ToResolverCache should return a Dictionary #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lewurm, |
marek-safar
approved these changes
Jun 6, 2017
jonpryor
reviewed
Jun 6, 2017
| @@ -97,13 +97,9 @@ protected virtual void Dispose (bool disposing) | |||
| } | |||
|
|
|||
| [Obsolete ("Should not be used; was required with previous Cecil versions.")] | |||
There was a problem hiding this comment.
This [Obsolete] should also be removed.
fixes
```
Tasks/LinkAssemblies.cs(103,41): error CS1503: Argument 1: cannot convert from 'System.Collections.IDictionary' to 'System.Collections.Generic.Dictionary<string, Mono.Cecil.AssemblyDefinition>'
```
in xamarin-android
lewurm
force-pushed
the
toresolvercachefix
branch
from
07a97df to
d1c06b2
Compare
|
@jonpryor thanks! PR updated |
jonpryor
added a commit
to jonpryor/java.interop
that referenced
this pull request
Mar 14, 2022
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1397171 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1433453 Changes: http://github.com/xamarin/xamarin-android-tools/compare/34e98e2b65917d105169f868b5648f67e68b6784...f4c44e2ac2d91396226f31e8c200464ecc65f648 * dotnet/android-tools@f4c44e2: [Xamarin.Android.Tools.AndroidSdk] Attributes can be null! (dotnet#158) * dotnet/android-tools@f0b3abd: Revert "[Xamarin.Android.Tools.AndroidSdk] Update SDK component for API-32 (dotnet#156)" * dotnet/android-tools@bbe85df: [Xamarin.Android.Tools.AndroidSdk] Update SDK component for API-32 (dotnet#156) * dotnet/android-tools@a7f4d30: [ci] Mention new NuGet feed and release (dotnet#153) * dotnet/android-tools@85ae77f: Merge pull request dotnet#152 from xamarin/dev/mattnorflus/SigningMigration * dotnet/android-tools@dd34e54: Adding condition to GetFilesToSign to only include files if build configuration is Release * dotnet/android-tools@0e80ea1: Bump LibZipSharp to 2.0.3 (dotnet#151) * dotnet/android-tools@d0ab6ac: Fix Typo in commit 0dcf7172 (dotnet#150) * dotnet/android-tools@0dcf717: Bump LibZipSharp to 2.0.2 (dotnet#149) * dotnet/android-tools@db125a7: [build] Add d17-* as a branch trigger * dotnet/android-tools@f2cbc6a: Add resource dlls to MicroBuild signing. (dotnet#145) * dotnet/android-tools@35c89dd: Update MaximumCompatibleNDKMajorVersion to be 23 (dotnet#144) * dotnet/android-tools@0a22957: [Xamarin.Android.Tools.AndroidSdk] Parse Properties after header (dotnet#143) * dotnet/android-tools@dac3a47: [Xamarin.Android.Tools.AndroidSdk] Add API-31 to KnownVersions (dotnet#141) * dotnet/android-tools@fc976d8: [Xamarin.Android.Tools.AndroidSdk] Add JdkInfo.GetSupportedJdkInfos() (dotnet#142)
jonpryor
added a commit
that referenced
this pull request
Mar 14, 2022
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1397171 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1433453 Changes: http://github.com/xamarin/xamarin-android-tools/compare/34e98e2b65917d105169f868b5648f67e68b6784...f4c44e2ac2d91396226f31e8c200464ecc65f648 * dotnet/android-tools@f4c44e2: [Xamarin.Android.Tools.AndroidSdk] Attributes can be null! (#158) * dotnet/android-tools@f0b3abd: Revert "[Xamarin.Android.Tools.AndroidSdk] Update SDK component for API-32 (#156)" * dotnet/android-tools@bbe85df: [Xamarin.Android.Tools.AndroidSdk] Update SDK component for API-32 (#156) * dotnet/android-tools@a7f4d30: [ci] Mention new NuGet feed and release (#153) * dotnet/android-tools@85ae77f: Merge pull request #152 from xamarin/dev/mattnorflus/SigningMigration * dotnet/android-tools@dd34e54: Adding condition to GetFilesToSign to only include files if build configuration is Release * dotnet/android-tools@0e80ea1: Bump LibZipSharp to 2.0.3 (#151) * dotnet/android-tools@d0ab6ac: Fix Typo in commit 0dcf7172 (#150) * dotnet/android-tools@0dcf717: Bump LibZipSharp to 2.0.2 (#149) * dotnet/android-tools@db125a7: [build] Add d17-* as a branch trigger * dotnet/android-tools@f2cbc6a: Add resource dlls to MicroBuild signing. (#145) * dotnet/android-tools@35c89dd: Update MaximumCompatibleNDKMajorVersion to be 23 (#144) * dotnet/android-tools@0a22957: [Xamarin.Android.Tools.AndroidSdk] Parse Properties after header (#143) * dotnet/android-tools@dac3a47: [Xamarin.Android.Tools.AndroidSdk] Add API-31 to KnownVersions (#141) * dotnet/android-tools@fc976d8: [Xamarin.Android.Tools.AndroidSdk] Add JdkInfo.GetSupportedJdkInfos() (#142)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
in xamarin-android