Bump to mono/LineEditor/v5.4.1@3fa0c2eb (#740) #766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1230070 Changes: mono/LineEditor@5a7e3e2...3fa0c2e * mono/LineEditor@3fa0c2e: Fix NuGet publishing errors (dotnet#9) * mono/LineEditor@06a4ddf: Bump `$(PackageVersion)` to 5.4.1. * mono/LineEditor@bce1b7f: Enable .pdb files for Release config & add AzDO build script (dotnet#8) * mono/LineEditor@4831e1a: Merge pull request dotnet#6 from terrajobst/code-of-conduct * mono/LineEditor@5b4a4aa: Link Code of Conduct * mono/LineEditor@410ca3d: Merge pull request dotnet#2 from VEIT-Electronics/master * mono/LineEditor@3d802e7: Merge pull request dotnet#1 from VEIT-Electronics/bugfix/ENG-232-line-editor-completions * mono/LineEditor@0d43552: fix: text overriding was only platform specific (check platform) The most important piece is mono/LineEditor@bce1b7f, which will allow us to redistribute `LineEditor.pdb` in the Xamarin.Android installers. Add a post-`Build` target to `logcat-parse/Directory.Build.targets` which copies `LineEditor.pdb` into `$(OutputPath)`. This will allow the Xamarin.Android installer to include `LineEditor.pdb` into the installer packages.
radekdoulik
reviewed
Dec 18, 2020
|
It still fails. I remember seeing this in JI when |
|
Here it fails when building |
|
I think we got an exception for this and this will not need to be merged as it has been fixed in d16-9 / master, but I will leave this open for a bit longer to confirm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1230070
Changes: mono/LineEditor@5a7e3e2...3fa0c2e
$(PackageVersion)to 5.4.1.JavaException.InnerExceptionshould returnThrowable.getCause(). #1 from VEIT-Electronics/bugfix/ENG-232-line-editor-completionsThe most important piece is mono/LineEditor@bce1b7f, which will allow
us to redistribute
LineEditor.pdbin the Xamarin.Android installers.Add a post-
Buildtarget tologcat-parse/Directory.Build.targetswhich copies
LineEditor.pdbinto$(OutputPath). This will allowthe Xamarin.Android installer to include
LineEditor.pdbinto theinstaller packages.