[build] Import $(MSBuildProjectDirectory).override.props #872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b6431ac introduced support for
Configuration.Override.props
,which eventually allowed overriding the
external/xamarin-android-tools
path via the
$(XamarinAndroidToolsDirectory)
MSBuild property incommit 32f0c9c.
A problem with this approach is that it requires that the host repo
create the
Java.Interop/Configuration.Override.props
file beforerunning
make -C …/Java.Interop prepare
.This can be simplified: update
Directory.Build.props
so that itwill also
<Import/>
the file$(MSBuildProjectDirectory).override.props
.$(MSBuildProjectDirectory)
is:The "Do not" is grammatically odd, as it's set by MSBuild.
It does not include a final backslash.
This means that we can place the
.override.props
file in thedirectory containing the Java.Interop checkout, with a name that
matches the git submodule directory name: