Analyzer test infra improvements #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When diagnostics are missing, display all missing diagnostics - Show candidate diagnostics that didn't match any expected ones - Adjust match criteria to match Roslyn strings - Various small fixes
- Clean up nullable annotations in test infra - Remove cctor warnings from analyzer to match linker - Remove redundant attribute property setter warnings - Fix location filtering for warnings that originate from types
sbomer
force-pushed
the
analyzerTestInfraImprovements
branch
from
9e879d7
to
75e9290
Compare
|
@mateoatr once this is ready I plan to merge the changes from main into the DAM feature branch. These changes should make it easier to add coverage by sharing tests with the linker. PTAL when you have a chance! |
|
This LGTM. I think we are almost on par with what we have under |
mateoatr
approved these changes
Sep 29, 2021
This was referenced Sep 29, 2021
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Improve analyzer test checker - When diagnostics are missing, display all missing diagnostics - Show candidate diagnostics that didn't match any expected ones - Adjust match criteria to match Roslyn strings - Clean up nullable annotations in test infra - Remove cctor warnings from analyzer to match linker - Remove redundant attribute property setter warnings - Fix location filtering for warnings that originate from types Commit migrated from dotnet/linker@640878a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the analyzer test validation more similar to the linker test validation and adds extra reporting when tests fail. The change caught a few differences between the linker and analyzer behavior:
As part of this I also had to tweak the logic for checking whether a diagnostic originates from a particular member.