[feature/damAnalyzer] Remove reflection access patterns from tests #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-karas
changed the title
tlakollo
reviewed
Dec 14, 2021
…nalyzer test infra support for this
tlakollo
approved these changes
Dec 15, 2021
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…otnet/linker#2444) Removes the `RecodnizedReflectionAccessPattern` and `UnrecognizedReflectionAccessPattern` attributes and all of the infrastructure for it. In the tests this is replaced by: * `ExpectedNoWarning` on the test level which makes sure we don't produce unexpected warnings (basically equivalent to `RecognizedReflecitonAccessPattern`. * `ExpectedWarning` to mark the places where warning should be generated - direct replacement for `UnrecognizedReflectionAccessPattern`. This change also removes some of the test-private helpers and replaces it with the `DataFlowTypeExtensions` helpers. This is mostly a mechanical change. This is part of the work to remove reflection access patterns from everywhere - in order to make the data flow logic sharable with the analyzer. Commit migrated from dotnet/linker@6e28469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
RecodnizedReflectionAccessPatternandUnrecognizedReflectionAccessPatternattributes and all of the infrastructure for it.In the tests this is replaced by:
ExpectedNoWarningon the test level which makes sure we don't produce unexpected warnings (basically equivalent toRecognizedReflecitonAccessPattern.ExpectedWarningto mark the places where warning should be generated - direct replacement forUnrecognizedReflectionAccessPattern.This change also removes some of the test-private helpers and replaces it with the
DataFlowTypeExtensionshelpers.This is mostly a mechanical change.
This is part of the work to remove reflection access patterns from everywhere - in order to make the data flow logic sharable with the analyzer.