Warn on TrimMode=copyused #3042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-karas
reviewed
Sep 20, 2022
Comment on lines
208
to
209
| <Warning Condition="'$(TrimMode)' == 'copyused' And $([MSBuild]::VersionGreaterThan('$(TargetFrameworkVersion)', '6.0'))" | ||
| Text="TrimMode 'copyused' is deprecated in .NET 7. Use TrimMode 'full' or 'partial' instead." /> |
There was a problem hiding this comment.
The only thing which worries me about this is that it's basically impossible to suppress this warning. Which might break people's builds.
There was a problem hiding this comment.
I think we agreed offline that any change here is pretty risky for .NET 7. I changed it to produce a warning and ignore unsupported values in .NET 8 only, with a warning. I also added _TrimMode as an escape hatch similar to _TrimmerDefaultAction.
vitek-karas
reviewed
Sep 21, 2022
|
@sbomer should this PR be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3039
Warns if using deprecated
TrimMode=copyusedin net7.0. Also sets the default action tocopyas a fallback when not usingTrimModefullorpartialin 7.0.