Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove learningRate argument from FastForest constructor #2237

Closed
singlis opened this issue Jan 24, 2019 · 1 comment · Fixed by #2691
Closed

Remove learningRate argument from FastForest constructor #2237

singlis opened this issue Jan 24, 2019 · 1 comment · Fixed by #2691
Assignees
@singlis
Labels
API Issues pertaining the friendly API

Comments

@singlis
Copy link
Member

singlis commented Jan 24, 2019

Started from issue #1983 where there is a comment about learningRate is accessible from the FastForest constructor but not accessible from the FastForest Arguments (now Options) class. After investigating, learningRate is not an argument for FastForest and that it was added to the constructor by mistake.

For this issue, the fix is to remove learningRate from the constructor for FastForest and update the code/tests as needed:

machinelearning/src/Microsoft.ML.FastTree/RandomForestClassification.cs

Line 155 in 1baaec3

double learningRate = Defaults.LearningRates)

@singlis singlis self-assigned this Jan 24, 2019
@singlis singlis mentioned this issue Jan 24, 2019
Closed
@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Feb 21, 2019
@Ivanidzo4ka
Copy link
Contributor

related to #2617

singlis added a commit to singlis/machinelearning that referenced this issue Feb 22, 2019
@singlis
Removes the learning rate parameter from RandomForest as this paramet…
7f67015 
…er was not used

by the base class.

This fixes dotnet#2237
@singlis singlis mentioned this issue Feb 22, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@singlis singlis

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove learningRate parameter from RandomForest singlis/machinelearning
2 participants
@Ivanidzo4ka @singlis