Static pipelines now handle types with PipelineColumn properties. #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
requested review from
Ivanidzo4ka,
GalOshri,
sfilipi,
zeahmed and
Zruty0
|
Oh macOS Build_Debug... you kidder. |
* Update the internal infrastructure to accomodate these types, * Update the Roslyn analyzer to accomodate these types. * Update the tests so that they exercise this capability. * Opportunistically fix some problems with the Roslyn analyzer brought up in this work.
Zruty0
reviewed
Oct 2, 2018
| @@ -37,28 +37,28 @@ public static class StaticPipeUtils | |||
| /// <typeparam name="TIn">The type parameter for the input type to the data reader estimator.</typeparam> | |||
| /// <typeparam name="TDelegateInput">The input type of the input delegate. This might be some object out of | |||
| /// which one can fetch or else retrieve </typeparam> | |||
| /// <typeparam name="TTupleOutShape"></typeparam> | |||
| /// <typeparam name="TOutShape"></typeparam> | |||
There was a problem hiding this comment.
typeparam [](start = 13, length = 9)
remove empty #Resolved
Zruty0
reviewed
Oct 2, 2018
|
|
||
| Helper(schema, "how.Stuff.hi", BoolType.Instance); | ||
| Helper(schema, "how.Stuff.my.Foo", TextType.Instance); | ||
| Helper(schema, "how.Stuff.my.Bar", new VectorType(NumberType.Float, 4)); |
There was a problem hiding this comment.
how.Stuff.my.Bar [](start = 28, length = 16)
'how stuff my bar', hmm...
In the spirit of open-source, should we have a bit more, um, mature naming scheme?.. #Resolved
There was a problem hiding this comment.
TomFinley
force-pushed
the
tfinley/Type
branch
from
22399ab
to
ad1f25c
Compare
|
Same test failed... MulticlassTreeFeaturizedLRTest. But with a different bad range. Not sure what's up with that, I definitely didn't touch anything related to that test. In reply to: 426148269 [](ancestors = 426148269) |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brought up in this work.
Fixes #1085.