Prevent learning pipeline from adding null transform model to the pipeline #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanidzo4ka
reviewed
May 15, 2018
| @@ -182,7 +182,9 @@ public LearningPipeline() | |||
|
|
|||
| if (transformModels.Count > 0) | |||
| { | |||
| transformModels.Insert(0,lastTransformModel); | |||
| if (lastTransformModel != null) | |||
| transformModels.Insert(0, lastTransformModel); | |||
There was a problem hiding this comment.
transformModels [](start = 24, length = 15)
would be nice to add test coverage
Ivanidzo4ka
reviewed
May 15, 2018
| else | ||
| Assert.Equal(0, predictionModel.TransformedF1[index]); | ||
|
|
||
| predictionModel.TransformedF1 = null; |
There was a problem hiding this comment.
predictionModel.TransformedF1 = null; [](start = 11, length = 38)
out of curiosity, why? #Closed
There was a problem hiding this comment.
compiler warning that is treated as an error.
Ivanidzo4ka
reviewed
May 15, 2018
| public string F1; | ||
| } | ||
|
|
||
| class TransformedData |
There was a problem hiding this comment.
explicit access modifer, same for class above #Closed
zeahmed
reviewed
May 15, 2018
| const string _dataPath = @"..\..\Data\breast-cancer.txt"; | ||
| var pipeline = new LearningPipeline(); | ||
| pipeline.Add(new TextLoader<InputData>(_dataPath, useHeader: false)); | ||
| pipeline.Add(new CategoricalHashOneHotVectorizer("F1") { HashBits = 10, Seed = 314489979, OutputKind = CategoricalTransformOutputKind.Bag }); |
There was a problem hiding this comment.
Is this issue only affecting transforms only pipeline?
zeahmed
approved these changes
May 15, 2018
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
…eline (dotnet#154) * Prevent learning pipeline from adding null transform model to the pipeline. * Add test.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #153