Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update macOS Prerequisites #1674

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Update macOS Prerequisites #1674

merged 1 commit into from
Nov 19, 2018

Conversation

eerhardt
Copy link
Member

Updating macOS prerequisites to the latest dependencies

@eerhardt
Update macOS Prerequisites
4047861 
Updating macOS prerequisites to the latest dependencies
Anipik
Anipik approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ivanidzo4ka
Ivanidzo4ka reviewed Nov 19, 2018
View reviewed changes
docs/building/unix-instructions.md
* gcc
* libomp
* libgdiplus
* gettext
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libomp for MKL I assume, libgdiplus for System.Drawing, what gettext for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libomp is for LightGBM.

libgdiplus is for System.Drawing. I guess gettext is for libgdiplus: https://github.com/mono/libgdiplus/blob/f1dfa1bf87b26dfe74448a3fff9716793a78e98e/README.md#requirements

Ivanidzo4ka
Ivanidzo4ka approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@TomFinley
Copy link
Contributor

Our of curiosity, we used to need gcc I think for LightGBM since otherwise the package would not work, but I see we've explicitly deleted that -- has that issue been resolved somehow?

@eerhardt
Copy link
Member Author

Our of curiosity, we used to need gcc I think for LightGBM since otherwise the package would not work, but I see we've explicitly deleted that -- has that issue been resolved somehow?

Yes, the latest LightGBM for macOS no longer explicitly requires gcc. Instead, it just requires libomp.

See microsoft/LightGBM#1523
https://github.com/Microsoft/LightGBM/pull/1676/files#diff-f54ede2a43d00dde2f6ff27364db0e9dR67

Note: this command is the exact command that our PR validation builds use:

machinelearning/build/ci/phase-template.yml

Line 28 in 6c5677a

- script: brew install libomp mono-libgdiplus gettext && brew link gettext --force

And they run on "normal" macOS machines.

@eerhardt eerhardt merged commit b72117e into master Nov 19, 2018
@eerhardt eerhardt deleted the eerhardt-patch-1 branch November 19, 2018 23:20
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Anipik Anipik Anipik approved these changes

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@codemzs codemzs Awaiting requested review from codemzs

@artidoro artidoro Awaiting requested review from artidoro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eerhardt @TomFinley @Ivanidzo4ka @Anipik