Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up of TextLoader constructor #1784

Merged
merged 9 commits into from
Dec 7, 2018
Merged

Clean up of TextLoader constructor #1784

merged 9 commits into from
Dec 7, 2018

Commits on Dec 6, 2018

  1. textloader refactoring of constructor

    @artidoro
    artidoro committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    a6e4fd8 View commit details
    Browse the repository at this point in the history

  2. added comments and fixed bugs

    @artidoro
    artidoro committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    75254c5 View commit details
    Browse the repository at this point in the history

  3. made create methods internal and adjusted code accordingly

    @artidoro
    artidoro committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    2986558 View commit details
    Browse the repository at this point in the history

  4. kept overload with Arguments and removed advanced settings

    @artidoro
    artidoro committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    f04cd68 View commit details
    Browse the repository at this point in the history

  5. review comments

    @artidoro
    artidoro committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    d90c116 View commit details
    Browse the repository at this point in the history

  6. removed ReadFile, only kept MlContext ReadFromTextFile

    @artidoro
    artidoro committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    a52849c View commit details
    Browse the repository at this point in the history

  7. updated Cookbook.md, and renamed static extension

    @artidoro
    artidoro committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    358a709 View commit details
    Browse the repository at this point in the history

  8. fixed bug

    @artidoro
    artidoro committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    52c91a2 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. review comments, added back the readfile method but made it internal

    @artidoro
    artidoro committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    8643afe View commit details
    Browse the repository at this point in the history