Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML.NET-242: FastTreeRanking per-iteration loss metrics are empty #289

Merged
merged 1 commit into from
Jun 4, 2018
Merged

ML.NET-242: FastTreeRanking per-iteration loss metrics are empty #289

merged 1 commit into from
Jun 4, 2018
+3 −0

Commits on Jun 2, 2018

  1. ML.NET-242: FastTreeRanking per-iteration loss metrics are empty 

    When training a FastTreeRanker using the `testFrequency` parameter, it is expected that NDCG is prented every testFrequency iterations. However, instead of NDCG, only empty strings are printed.

The root cause was that the MaxDCG property of the dataset was never calculated, so the NDCG calculation is aborted, leaving an empty string as a result.

This PR fixes the problem by computing the MaxDCG for the dataset when the Tests are defined (so that if the tests are not defined, the MaxDCG will never be calculated).

Closes dotnet#242
    Rogan Carr committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    79a437e View commit details
    Browse the repository at this point in the history