Internalize LpNorm column options. #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
requested review from
Ivanidzo4ka,
shauheen,
yaeldekel,
artidoro and
sfilipi
rogancarr
approved these changes
Mar 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #3078 +/- ##
==========================================
- Coverage 72.52% 72.52% -0.01%
==========================================
Files 806 806
Lines 144500 144500
Branches 16191 16191
==========================================
- Hits 104804 104792 -12
- Misses 35290 35299 +9
- Partials 4406 4409 +3
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refinement of the PR #2959. I noticed that a few of the
ColumnOptionsclasses, including a base class, were still appearing in the public API. Also hide theIReadOnlyList<...>to access it through the columns as we do not want to do that per @Ivanidzo4ka.