-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoML] CLI CodeGen printing L1 instead of RMS #3459
[AutoML] CLI CodeGen printing L1 instead of RMS #3459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this,
@@ -188,18 +188,18 @@ else{#> | |||
{ | |||
var L1 = crossValidationResults.Select(r => r.Metrics.MeanAbsoluteError); | |||
var L2 = crossValidationResults.Select(r => r.Metrics.MeanSquaredError); | |||
var RMS = crossValidationResults.Select(r => r.Metrics.MeanAbsoluteError); | |||
var RMS = crossValidationResults.Select(r => r.Metrics.RootMeanSquaredError); | |||
var lossFunction = crossValidationResults.Select(r => r.Metrics.LossFunction); | |||
var R2 = crossValidationResults.Select(r => r.Metrics.RSquared); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong in here. Looks like you have changed tt file but no corresponding change in .cs file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something wrong with template generation code. Need to update .cs files
Not sure how you updated the tt file without changes to its respective cs file. Are you using any other editor other than visual studio to edit the template?
Fixed this issue in above referenced PR |
CodeGen was printing the L1 Error in the RMS field.
Notice the
298.351
twice.