Checked in a better fix based on code review #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging to personal fork
Syncing upstream fork
wschin
approved these changes
Jun 21, 2019
|
Do we still want/need this change?
Or should that be reverted as well? |
eerhardt
reviewed
Jun 21, 2019
eerhardt
reviewed
Jun 21, 2019
|
@eerhardt I have updated the message. Please take a look. |
eerhardt
approved these changes
Jun 24, 2019
Dmitry-A
pushed a commit
to Dmitry-A/machinelearning
that referenced
this pull request
Jul 24, 2019
* Fixed build errors resulting from upgrade to VS2019 compilers * Added additional message describing the previous fix * Checked in a better fix based on code review * Updated message
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3893
The earlier fix was clobbering theCMake defaults. @janvorli suggested a better fix to simply replace the offending flag. This checkin has that fix.