Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable macOS tests for LightGBM. #422

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Enable macOS tests for LightGBM. #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions test/Microsoft.ML.Predictor.Tests/TestAutoInference.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ public TestAutoInference(ITestOutputHelper helper)
[TestCategory("EntryPoints")]
public void TestLearn()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

using (var env = new TlcEnvironment())
{
string pathData = GetDataPath("adult.train");
Expand Down Expand Up @@ -280,11 +275,6 @@ public void EntryPointPipelineSweep()
[Fact]
public void TestRocketPipelineEngine()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

// Get datasets
var pathData = GetDataPath("adult.train");
var pathDataTest = GetDataPath("adult.test");
Expand Down
40 changes: 0 additions & 40 deletions test/Microsoft.ML.Predictor.Tests/TestPredictors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,11 +413,6 @@ public void FastTreeBinaryClassificationTest()
[TestCategory("LightGBM")]
public void LightGBMClassificationTest()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

var learners = new[] { TestLearners.LightGBMClassifier };
var binaryClassificationDatasets = new List<TestDataset> { TestDatasets.breastCancerPipe };
foreach (var learner in learners)
Expand All @@ -433,11 +428,6 @@ public void LightGBMClassificationTest()
[TestCategory("Binary"), TestCategory("LightGBM")]
public void GossLightGBMTest()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

var binaryPredictors = new[] { TestLearners.LightGBMGoss };
var binaryClassificationDatasets = new List<TestDataset> { TestDatasets.breastCancerPipe };
RunAllTests(binaryPredictors, binaryClassificationDatasets, extraTag: "goss");
Expand All @@ -449,11 +439,6 @@ public void GossLightGBMTest()
[TestCategory("LightGBM")]
public void DartLightGBMTest()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

var binaryPredictors = new[] { TestLearners.LightGBMDart };
var binaryClassificationDatasets = new List<TestDataset> { TestDatasets.breastCancerPipe };
RunAllTests(binaryPredictors, binaryClassificationDatasets, extraTag: "dart");
Expand All @@ -468,11 +453,6 @@ public void DartLightGBMTest()
[TestCategory("LightGBM")]
public void MultiClassifierLightGBMKeyLabelTest()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

var multiPredictors = new[] { TestLearners.LightGBMMC };
var multiClassificationDatasets = new[] { TestDatasets.irisLoader };
RunAllTests(multiPredictors, multiClassificationDatasets, extraTag: "key");
Expand All @@ -487,11 +467,6 @@ public void MultiClassifierLightGBMKeyLabelTest()
[TestCategory("LightGBM")]
public void MultiClassifierLightGBMKeyLabelU404Test()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

var multiPredictors = new[] { TestLearners.LightGBMMC };
var multiClassificationDatasets = new[] { TestDatasets.irisLoaderU404 };
RunAllTests(multiPredictors, multiClassificationDatasets, extraTag: "keyU404");
Expand All @@ -506,11 +481,6 @@ public void MultiClassifierLightGBMKeyLabelU404Test()
[TestCategory("LightGBM")]
public void RegressorLightGBMTest()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

var regPredictors = new[] { TestLearners.LightGBMReg };
var regDatasets = new[] { TestDatasets.winequality };
RunAllTests(regPredictors, regDatasets);
Expand All @@ -525,11 +495,6 @@ public void RegressorLightGBMTest()
[TestCategory("LightGBM")]
public void RegressorLightGBMMAETest()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

var regPredictors = new[] { TestLearners.LightGBMRegMae };
var regDatasets = new[] { TestDatasets.winequality };
RunAllTests(regPredictors, regDatasets, extraTag: "MAE");
Expand All @@ -544,11 +509,6 @@ public void RegressorLightGBMMAETest()
[TestCategory("LightGBM")]
public void RegressorLightGBMRMSETest()
{
//Skip this test for macOS until engineering system installs OpenMP dependency for
//native LightGBM library.
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return;

var regPredictors = new[] { TestLearners.LightGBMRegRmse };
var regDatasets = new[] { TestDatasets.winequality };
RunAllTests(regPredictors, regDatasets, extraTag: "RMSE");
Expand Down