-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tensorflow.net to 0.20.0 #5404
Merged
LittleLittleCloud
merged 28 commits into
dotnet:master
from
LittleLittleCloud:u/xiaoyun/updateTensorflow.Net
Oct 13, 2020
Merged
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c073e6b
upgrade to 3.1
LittleLittleCloud 8f0fc1a
write inline data using invariantCulture
LittleLittleCloud e96d716
Merge branch 'master' of https://github.com/dotnet/machinelearning
LittleLittleCloud 8c17bbe
Merge branch 'master' of https://github.com/dotnet/machinelearning
LittleLittleCloud b2947f5
Merge branch 'master' of https://github.com/dotnet/machinelearning
LittleLittleCloud ff1c909
Merge branch 'master' of https://github.com/dotnet/machinelearning
LittleLittleCloud dad9055
Merge branch 'master' of https://github.com/dotnet/machinelearning
LittleLittleCloud 741d77a
Merge branch 'master' of https://github.com/dotnet/machinelearning
LittleLittleCloud 594c828
Merge branch 'master' of https://github.com/dotnet/machinelearning
LittleLittleCloud cc4def8
Merge branch 'master' of https://github.com/dotnet/machinelearning
LittleLittleCloud 7cd6d8a
upodate tensorflow
fdf7b73
update Microsoft.ML.Vision
d0c261e
fix test && comment
48064a1
udpate tensorflow.net to 0.20.1
35d4e25
update tf major version
2aafe7b
downgrade tf runtime to 1.14.1
e7e657c
Update Dependencies.props
LittleLittleCloud b92bc45
Update Dependencies.props
LittleLittleCloud b314ea5
update tffact to stop running test on linux with glibc < 2.3)
80f3c16
fix TensorFlowTransformInputShapeTest
65271c3
use tf.v1 api
ec4a5ee
fix comment:
LittleLittleCloud df6cbcb
fix building error
LittleLittleCloud 0610a9b
Merge branch 'master' of https://github.com/dotnet/machinelearning
LittleLittleCloud 159d17c
Merge branch 'master' into u/xiaoyun/updateTensorflow.Net
LittleLittleCloud 3d00c41
fix test
LittleLittleCloud fae6864
fix nit
LittleLittleCloud 5f3e34b
remove linq
LittleLittleCloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using Linq here, I would keep the loop and
new string[data.Length]
code that you had before. It will achieve better performance since you will only allocate a single array.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite follow here, the size of
data
is fixed, so where will the second memory allocation be when callingToArray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is that
Select
where the n memory allocation will beThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - the
Select
will cause an allocation:https://github.com/dotnet/runtime/blob/4486164506a56200e66cf4cd750fde6b54ab5abd/src/libraries/System.Linq/src/System/Linq/Select.cs#L37