Add analayzer to nuget

[TomFinley]

More completion for #778, where I add the code analyzer to the nuget.

Thanks for help from @eerhardt !

[eerhardt]

Thinking a bit more on this, we could integrate this into the existing PreparePackageAssets target. I think it would help eliminate a little bit of duplication, and ensure one usage of the PackageAsset item.

Basically just change

machinelearning/src/Directory.Build.targets

Lines 5 to 21 in eb26489

	<Target Name="PreparePackageAssets"
	AfterTargets="Build"
	Condition="'$(IncludeInPackage)' != ''">
	<ItemGroup>
	<PackageAsset Include="$(TargetPath)"
	RelativePath="$(IncludeInPackage)\lib\$(TargetFramework)" />
	<PackageAsset Include="@(DebugSymbolsProjectOutputGroupOutput)"
	RelativePath="$(IncludeInPackage)\lib\$(TargetFramework)" />
	<PackageAsset Include="@(DocumentationProjectOutputGroupOutput)"
	RelativePath="$(IncludeInPackage)\lib\$(TargetFramework)" />
	</ItemGroup>
	<Copy SourceFiles="@(PackageAsset)"
	DestinationFolder="$(PackageAssetsPath)%(PackageAsset.RelativePath)" />
	</Target>

to be:

  <Target Name="PreparePackageAssets"
          AfterTargets="Build">

    <ItemGroup Condition="'$(IncludeInPackage)' != ''">
      <PackageAsset Include="$(TargetPath)"
                    RelativePath="$(IncludeInPackage)\lib\$(TargetFramework)" />
      <PackageAsset Include="@(DebugSymbolsProjectOutputGroupOutput)"
                    RelativePath="$(IncludeInPackage)\lib\$(TargetFramework)" />
      <PackageAsset Include="@(DocumentationProjectOutputGroupOutput)"
                    RelativePath="$(IncludeInPackage)\lib\$(TargetFramework)" />
    </ItemGroup>

    <ItemGroup Condition="'$(IncludeAnalyzerInPackage)' != ''">
      <PackageAsset Include="$(TargetPath)"
                    RelativePath="$(IncludeAnalyzerInPackage)\analyzers\dotnet\cs" />
      <PackageAsset Include="@(DebugSymbolsProjectOutputGroupOutput)"
                    RelativePath="$(IncludeAnalyzerInPackage)\analyzers\dotnet\cs" />
    </ItemGroup>

    <Copy SourceFiles="@(PackageAsset)"
          DestinationFolder="$(PackageAssetsPath)%(PackageAsset.RelativePath)" />

  </Target>

Then all you need to do in this file is set <IncludeAnalyzerInPackage>Microsoft.ML</IncludeAnalyzerInPackage> like you are above.

[TomFinley]

Great, thanks @eerhardt -- now updated, and I've rechecked the nuget.

---

In reply to: 219938652 [](ancestors = 219938652)

[eerhardt]

[eerhardt]

Thanks!

[ericstj]

We may want to double check that we don't need this dotnet to be parallel with other tfms in the package to avoid the package installing and only supplying an analyzer on a unsupported framework.

[ericstj]

In other words, don't reintroduce this issue: #357.

I think this should be simple to test, I'm not familiar enough with NuGet conventions for analyzers to know if it would have this problem without testing it.

[ericstj]

This may be an unfounded concern. I looked into how NuGet resolves these and its actually different than the rest of the content. Essentially these appear to be ignored by restore / package applicability checks, and just resolved via a separate content selection algo at build time (not restore time https://github.com/NuGet/NuGet.BuildTasks/blob/640c8e13a9b7ab6e86264a296638fbf3cc016ad1/src/Microsoft.NuGet.Build.Tasks/ResolveNuGetPackageAssets.cs#L371).

Net result, ignore this comment.

[TomFinley]

Cool!! Thanks for your attention though @ericstj