Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DotNetFinalVersionKind variable in yml #170

Merged
merged 11 commits into from
Nov 14, 2024
1 change: 0 additions & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<PreReleaseVersionLabel>rtm</PreReleaseVersionLabel>
<PreReleaseVersionIteration></PreReleaseVersionIteration>
<DotNetFinalVersionKind>release</DotNetFinalVersionKind>
<!-- Opt-out repo features -->
<UseVSTestRunner>true</UseVSTestRunner>
<UsingToolXliff>false</UsingToolXliff>
Expand Down
18 changes: 18 additions & 0 deletions eng/pipelines/maintenance-packages.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
parameters:
- name: DotNetFinalVersionKind
type: string
displayName: .NET Final Version Kind
values:
- none
- prerelease
- release
default: none

trigger:
batch: true
branches:
Expand All @@ -20,11 +30,18 @@ variables:
value: ''
- name: _BuildJobDisplayName
value: 'Build and Test'
- name: _DotNetFinalVersionKind
value: ''
- ${{ else }}:
- name: _AdditionalBuildArgs
value: '/p:Test=false'
- name: _BuildJobDisplayName
value: 'Build, Sign and Publish'
- name: _DotNetFinalVersionKind
carlossanlop marked this conversation as resolved.
Show resolved Hide resolved
${{ if eq(parameters.DotNetFinalVersionKind, 'none') }}:
value: ''
${{ else }}:
value: /p:DotNetFinalVersionKind=${{ parameters.DotNetFinalVersionKind }}

resources:
repositories:
Expand Down Expand Up @@ -91,6 +108,7 @@ extends:
-configuration Release
-prepareMachine
/p:Test=false
$(_DotNetFinalVersionKind)
$(_AdditionalBuildArgs)
$(_InternalBuildArgs)
displayName: $(_BuildJobDisplayName)
Expand Down