-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package support policy #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
force-pushed
the
PackageSupportPolicy
branch
from
March 22, 2024 20:06
300bd85
to
dcee0df
Compare
carlossanlop
commented
Mar 22, 2024
ericstj
reviewed
Mar 25, 2024
carlossanlop
commented
Mar 29, 2024
Merged
carlossanlop
force-pushed
the
PackageSupportPolicy
branch
from
September 19, 2024 19:22
49532d6
to
834246c
Compare
ViktorHofer
reviewed
Oct 18, 2024
carlossanlop
force-pushed
the
PackageSupportPolicy
branch
from
November 8, 2024 01:30
0b4dfa1
to
90bc62f
Compare
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
carlossanlop
force-pushed
the
PackageSupportPolicy
branch
from
November 12, 2024 00:22
90bc62f
to
e80d961
Compare
carlossanlop
requested review from
ViktorHofer and
ericstj
and removed request for
directhex
November 12, 2024 00:22
@ericstj I addressed the feedback for Microsoft.CSharp that you gave me yesterday. |
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
carlossanlop
commented
Nov 13, 2024
3 tasks
ericstj
reviewed
Nov 13, 2024
David-Engel
reviewed
Nov 14, 2024
cheenamalhotra
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for SqlClient package.
carlossanlop
commented
Nov 14, 2024
ViktorHofer
reviewed
Nov 18, 2024
ViktorHofer
reviewed
Nov 18, 2024
ViktorHofer
reviewed
Nov 18, 2024
ericstj
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same file that we were originally submitting in dotnet/core, now moved here as discussed.