Make DisplayMemberName obsolete

dotnet · Feb 27, 2024 · a9b60fc · a9b60fc
1 parent 244d955
commit a9b60fc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSearchResultsRenderer.cs b/src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSearchResultsRenderer.cs
@@ -41,15 +41,19 @@ DataTemplate DefaultTemplate
 
 						if (RuntimeFeature.IsShellSearchResultsRendererDisplayMemberNameSupported)
 						{
+#pragma warning disable CS0618
 							label.SetBinding(Label.TextProperty, SearchHandler.DisplayMemberName ?? ".");
+#pragma warning restore CS0618
 						}
 						else
 						{
+#pragma warning disable CS0618
 							if (SearchHandler.DisplayMemberName is not null)
 							{
 								Application.Current?.FindMauiContext()?.CreateLogger<ShellSearchResultsRenderer>()?.LogError(TrimmerConstants.SearchHandlerDisplayMemberNameNotSupportedWarning);
 								throw new InvalidOperationException(TrimmerConstants.SearchHandlerDisplayMemberNameNotSupportedWarning);
 							}
+#pragma warning restore CS0618
 
 							label.SetBinding(Label.TextProperty, TypedBinding.ForSingleNestingLevel(string.Empty, static (object o) => o));
 						}

diff --git a/src/Controls/src/Core/Shell/SearchHandler.cs b/src/Controls/src/Core/Shell/SearchHandler.cs
@@ -361,9 +361,11 @@ void ISearchHandlerController.QueryConfirmed()
 			BindableProperty.Create(nameof(Command), typeof(ICommand), typeof(SearchHandler), null, BindingMode.OneTime,
 				propertyChanged: OnCommandChanged);
 
+#pragma warning disable CS0618
 		/// <summary>Bindable property for <see cref="DisplayMemberName"/>.</summary>
 		public static readonly BindableProperty DisplayMemberNameProperty =
 			BindableProperty.Create(nameof(DisplayMemberName), typeof(string), typeof(SearchHandler), null, BindingMode.OneTime);
+#pragma warning restore CS0618
 
 		/// <summary>Bindable property for <see cref="IsSearchEnabled"/>.</summary>
 		public static readonly BindableProperty IsSearchEnabledProperty =
@@ -498,6 +500,7 @@ public object CommandParameter
 		}
 
 		/// <include file="../../../docs/Microsoft.Maui.Controls/SearchHandler.xml" path="//Member[@MemberName='DisplayMemberName']/Docs/*" />
+		[Obsolete("Use ItemTemplate instead.")]
 		public string DisplayMemberName
 		{
 			get { return (string)GetValue(DisplayMemberNameProperty); }