Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression/7.0.0] [Android] Entry return type not rendering properly #17463

Closed
rachelkang opened this issue Sep 18, 2023 · 1 comment · Fixed by #17546
Closed

[regression/7.0.0] [Android] Entry return type not rendering properly #17463

rachelkang opened this issue Sep 18, 2023 · 1 comment · Fixed by #17546
Assignees
@jsuarezruiz
Labels
area-controls-entry Entry fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone
.NET 8 SR1

Comments

@rachelkang
Copy link
Member

Description

The ReturnType property on Entry is not working the way it should. On Android, the soft keyboard should present a different Return key depending on the ReturnType. However, it currently just shows the default check mark no matter what.

This is a regression, not yet sure from where. Unfortunately seeing it broken in .NET 8 rc1, but also seeing it broken as far back as 7.0.306.

Steps to Reproduce

  1. Create a File > New > .NET MAUI app
  2. Put the following in the XAML:
<Entry ReturnType="Done" />
<Entry ReturnType="Next" />
<Entry ReturnType="Go" />
<Entry ReturnType="Search" />
<Entry ReturnType="Send" />
  1. Deploy to an Android emulator
  2. Tap on each of the Entry fields and observe the ReturnType in the soft keyboard all shows a checkmark in the bottom right corner, instead of differentiating based on the ReturnType:
    image
image

Link to public reproduction project repository

https://github.com/dotnet/maui

Version with bug

8.0.0-rc.1.9171

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

Unknown/Other

Affected platforms

Android, I was not able test on other platforms

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response
@rachelkang rachelkang added t/bug Something isn't working platform/android 🤖 i/regression This issue described a confirmed regression on a currently supported version area-controls-entry Entry labels Sep 18, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Sep 18, 2023
@PureWeen PureWeen added this to the .NET 8 GA milestone Sep 18, 2023
@samhouts samhouts changed the title [Android] Entry return type not rendering properly [regression/7.0] [Android] Entry return type not rendering properly Sep 18, 2023
@samhouts samhouts changed the title [regression/7.0] [Android] Entry return type not rendering properly [regression/7.0.0] [Android] Entry return type not rendering properly Sep 18, 2023
@jsuarezruiz jsuarezruiz self-assigned this Sep 20, 2023
@rachelkang rachelkang mentioned this issue Sep 20, 2023
Merged
@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Sep 21, 2023
@XamlTest
Copy link

Verified this on Visual Studio Enterprise 17.8.0 Preview 2.0(8.0.0-rc.1.9171). Repro on Android 13.0-API33, not repro on iOS 16.4 with below Project:
17463.zip

Android:
Android
iOS:
iOS

@jsuarezruiz jsuarezruiz mentioned this issue Sep 21, 2023
Merged
rmarinho added a commit that referenced this issue Oct 4, 2023
@rmarinho
[Android] Fix ReturnType on Entry (#17546)
a05a5a7 
### Description of Change

Fix **ReturnType** on Android Entry. 

### Issues Fixed

Fixes #17463 

NOTE: It's marked as a regression from NET 7 but I can reproduce it in
NET 8 as well. So I would add it to main and then backport it.
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
@PureWeen PureWeen reopened this Nov 22, 2023
@samhouts samhouts added the fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! label Jan 31, 2024
@samhouts samhouts modified the milestones: .NET 8 GA, .NET 8 SR1 Jan 31, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
area-controls-entry Entry fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Milestone
.NET 8 SR1
Development

Successfully merging a pull request may close this issue.

[Android] Fix ReturnType on Entry dotnet/maui
6 participants
@Eilon @PureWeen @jsuarezruiz @samhouts @rachelkang @XamlTest