Publishing a Maui Windows app SelfContained=false doesn't run

[eerhardt]

Describe the bug

When I try to package, install, and run a Maui Windows app with SelfContained=false, it doesn't run. It pops up a dialog:

The reason this happens is because this is generated into the runtimeconfig.json file:

{
  "runtimeOptions": {
    "tfm": "net6.0",
    "frameworks": [
      {
        "name": "Microsoft.NETCore.App",
        "version": "6.0.0"
      },
      {
        "name": "Microsoft.Maui.Core",
        "version": "**FromWorkload**"
      },
      {
        "name": "Microsoft.Maui.Controls",
        "version": "**FromWorkload**"
      },
      {
        "name": "Microsoft.Maui.Essentials",
        "version": "**FromWorkload**"
      }
    ],
    "configProperties": {
      "System.Reflection.Metadata.MetadataUpdater.IsSupported": false,
      "System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization": false
    }
  }
}

Notice the FromWorkload things for Microsoft.Maui.*. These things shouldn't be in the runtimeconfig.json file. Removing them allows the app to proceed.

To Reproduce

0. Get Maui installed on your machine
1. dotnet new maui
2. Edit the .csproj to have:

		<WindowsPackageType>None</WindowsPackageType>
		<WinUISDKReferences>false</WinUISDKReferences>

		<SelfContained>false</SelfContained>

3. dotnet build -c Release -f net6.0-windows10.0.19041.0
4. Try to run the .exe in the bin\Release\net6.0-windows10.0.19041.0\win10-x64 folder.

Further technical details

❯ dotnet --info
.NET SDK (reflecting any global.json):
 Version:   6.0.300-preview.22207.16
 Commit:    1827808c3e

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.19043
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\git\maui\bin\dotnet\sdk\6.0.300-preview.22207.16\

Host (useful for support):
  Version: 6.0.3
  Commit:  c24d9a9c91

.NET SDKs installed:
  6.0.300-preview.22207.16 [C:\git\maui\bin\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.3 [C:\git\maui\bin\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.3 [C:\git\maui\bin\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 6.0.3 [C:\git\maui\bin\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET runtimes or SDKs:
  https://aka.ms/dotnet-download

cc @dsplaisted

[jfversluis]

Also noticed this when trying out the ClickOnce publishing, this seems to be the only thing from stopping that to work.

[dsplaisted]

I think what needs to happen is the Maui KnownFrameworkReference items should have RuntimePackAlwaysCopyLocal="true". This means that the SDK will copy the implementation from the runtime pack to the app even if the app is framework-dependent.

Additionally, I added a change to dotnet/sdk#25358 to support RuntimePackAlwaysCopyLocal runtime packs for RuntimeIdentifiers besides any. So we'll also need that change for this to work.

You'll also need to specify a RuntimeIdentifier when building the app, as there isn't a RuntimeIdentifier-agnostic version of the runtime pack available.

@jonathanpeppers @mattleibow @Redth

[dsplaisted]

Probably this should be transferred to the dotnet/maui repo, but it looks like I don't have permissions for that.

[jonathanpeppers]

@dsplaisted I moved this, thanks.

Should %(RuntimePackAlwaysCopyLocal) be based on if $(SelfContained) is false and $(TargetPlatformIdentifier) is Windows? Or just set it no matter what?

[dsplaisted]

It should be OK to set %(RuntimePackAlwaysCopyLocal) to true in all cases. It means that the contents of the runtime pack should be included in the app whether the app is self-contained or not.

[gerhard17]

I have the same problem, when using SelfContained (false). Compiling from Visual Studio 17.3.0 Preview 2.0 (windows)

[mattleibow]

@dsplaisted I tried setting this to true but then it fails for class libraries:

C:\Program Files\dotnet\sdk\6.0.400-preview.22301.10\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(430,5):
error NETSDK1082: There was no runtime pack for Microsoft.Maui.Core available for the specified RuntimeIdentifier 'any'.

It seems this ResolveRuntimePackAssets only runs on windows

msbuild (8).zip

[ghost]

Hi @eerhardt. We have added the "s/try-latest-version" label to this issue, which indicates that we'd like you to try and reproduce this issue on the latest available public version. This can happen because we think that this issue was fixed in a version that has just been released, or the information provided by you indicates that you might be working with an older version.

You can install the latest version by installing the latest Visual Studio (Preview) with the .NET MAUI workload installed. If the issue still persists, please let us know with any additional details and ideally a reproduction project provided through a GitHub repository.

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

[Zhanglirong-Winnie]

Verified this issue with Visual Studio Enterprise 17.7.0 Preview 5.0. Not repro on windows platform with cmd.