[controls] fix memory leak in CollectionView
#14329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-controls-collectionview
jonathanpeppers
force-pushed
the
windows-collectionview-leak
branch
from
f871ff3 to
6f74a43
Compare
Fixes: dotnet#10578 Context: https://github.com/Vroomer/MAUI-navigation-memory-leak.git After testing the above sample, I found that adding a `CollectionView` to a `Page`, makes it and the entire page live forever. Android & Windows: * `MauiRecyclerView` and `StructuredItemsViewHandler` respectively subscribed to `ItemsLayout.PropertyChanged`. This kept the `CollectionView` alive -> all the way up to the `Page`. * Switched to using `WeakNotifyPropertyChangedProxy` solved the issue for these two platforms. iOS: * Generally had a small "nest" of circular references. Initially, I saw `CollectionView`, `UICollectionView`, and various helper classes that would live forever. * `ItemsViewController : UICollectionViewController` -> * `ObservableItemsSource` -> * `UICollectionViewController` and `UICollectionView` * `UICollectionView` -> * `ItemsViewLayout : UICollectionViewFlowLayout` -> * `Func<UICollectionViewCell>` -> * `ItemsViewController : UICollectionViewController` -> * `UICollectionView` I switched to using `WeakReference<T>` to break the circular references. This required several null checks, where `null` references were not possible before. After these changes my tests pass, yay!
jonathanpeppers
force-pushed
the
windows-collectionview-leak
branch
from
6f74a43 to
fe9c697
Compare
rmarinho
reviewed
Apr 12, 2023
rmarinho
reviewed
Apr 12, 2023
rmarinho
approved these changes
Apr 12, 2023
This was referenced May 9, 2023
jonathanpeppers
added
the
memory-leak 💦
samhouts
added
the
fixed-in-8.0.0-preview.4.8333
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10578
Context: https://github.com/Vroomer/MAUI-navigation-memory-leak.git
After testing the above sample, I found that adding a
CollectionViewto aPage, makes it and the entire page live forever.Android & Windows:
MauiRecyclerViewandStructuredItemsViewHandlerrespectively subscribed toItemsLayout.PropertyChanged. This kept theCollectionViewalive -> all the way up to thePage.Switched to using
WeakNotifyPropertyChangedProxysolved the issue for these two platforms.iOS:
CollectionView,UICollectionView, and various helper classes that would live forever.I switched to using
WeakReference<T>to break the circular references. This required several null checks, wherenullreferences were not possible before.After these changes my tests pass, yay!