Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Label Multilinetruncation (MaxLines / LineBreakMode) #14918

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix Label Multilinetruncation (MaxLines / LineBreakMode) #14918

merged 1 commit into from
Jan 18, 2024

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented May 4, 2023 •
edited by mattleibow
Loading

Description of Change

Android iOS Windows
issue-13981-droid ios issue-13981-win

Summary:

  • The Button does not have the MaxLines property, it always stays with a single line and doing the tail truncation.
  • With a Label, if the maximum number of lines is not specified, when establishing the LineBreakMode.TailTruncation the maximum number of lines used is 1, and tail truncation is applied.
  • If MaxLines and LineBreakMode are established in the Label, both options are applied.

Issues Fixed

Fixes #14125

@jsuarezruiz jsuarezruiz added t/bug Something isn't working legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-label Label, Span labels May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

@jsuarezruiz jsuarezruiz marked this pull request as ready for review May 4, 2023 09:57
mattleibow
mattleibow reviewed May 4, 2023
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests we can add for these changes?

@jsuarezruiz
Copy link
Contributor Author

Are there any tests we can add for these changes?

Sure.
image

jfversluis
jfversluis previously approved these changes May 11, 2023
View reviewed changes
@EmanterolaDN
Copy link

One little step closer... Please someone who can merge it... 🙏

@jsuarezruiz jsuarezruiz marked this pull request as draft June 27, 2023 15:07
@jsuarezruiz jsuarezruiz marked this pull request as ready for review July 17, 2023 14:45
@Redth Redth requested a review from rachelkang July 26, 2023 14:53
rachelkang

This comment was marked as outdated.

Sign in to view

@samhouts samhouts added this to the .NET 8 GA milestone Jul 31, 2023
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner August 18, 2023 06:48
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Sep 11, 2023
@samhouts
Copy link
Member

Tests are failing?

@samhouts samhouts added the s/pr-needs-author-input PR needs an update from the author label Sep 11, 2023
@ghost ghost removed stale Indicates a stale issue/pr and will be closed soon s/pr-needs-author-input PR needs an update from the author labels Sep 12, 2023
@samhouts samhouts modified the milestones: .NET 8 GA, Under Consideration Sep 19, 2023
@ghost
Copy link

ghost commented Oct 16, 2023

Hi @jsuarezruiz. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

@samhouts
Copy link
Member

Please test changes against #18059, too. Thanks!

@dotnet dotnet deleted a comment Oct 18, 2023
@jsuarezruiz jsuarezruiz removed the s/pr-needs-author-input PR needs an update from the author label Oct 18, 2023
@jsuarezruiz
Copy link
Contributor Author

Please test changes against #18059, too. Thanks!

Added a specific device test to validate that case.

@hansmbakker
Copy link

Is it possible to include this PR in the next Servicing Release?

@mattleibow
Copy link
Member

/rebase

mattleibow
mattleibow previously approved these changes Jan 18, 2024
View reviewed changes
@mattleibow mattleibow force-pushed the fix-14125 branch 2 times, most recently from b5c8d17 to 880cd22 Compare January 18, 2024 00:38
mattleibow
mattleibow previously approved these changes Jan 18, 2024
View reviewed changes
@mattleibow
Copy link
Member

/rebase

@mattleibow
Copy link
Member

/rebase

@mattleibow @jsuarezruiz
Fix Label Multiline Truncation
d87f3aa 
Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
@jfversluis jfversluis merged commit 2c7dac7 into main Jan 18, 2024
47 checks passed
@jfversluis jfversluis deleted the fix-14125 branch January 18, 2024 11:03
simonrozsival pushed a commit to simonrozsival/maui that referenced this pull request Jan 19, 2024
@jsuarezruiz @mattleibow @simonrozsival
Fix Label Multiline Truncation (dotnet#14918)
466dbbc 
Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
@jsuarezruiz jsuarezruiz mentioned this pull request Jan 23, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@jfversluis jfversluis jfversluis approved these changes

@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque

@rachelkang rachelkang Awaiting requested review from rachelkang

Assignees
No one assigned
Labels
area-controls-label Label, Span fixed-in-8.0.7 fixed-in-9.0.100-preview.1.9973 t/bug Something isn't working
Projects
None yet
Milestone
.NET 8 SR3
Development

Successfully merging this pull request may close these issues.

[regression/7.0.0] Label Multilinetruncation (MaxLines / LineBreakMode)
8 participants
@jsuarezruiz @EmanterolaDN @samhouts @hansmbakker @mattleibow @jfversluis @rachelkang @Eilon