Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Themes #1657

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Implement Themes #1657

merged 5 commits into from
Jul 20, 2021

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jul 13, 2021

Description of Change

Include support for AppThemeBinding in Android and iOS. Add dark theme support to the Gallery too.

Android

gallery-light

gallery-dark

iOS
gallery-themes

Reviewing the Windows implementation. UISettings.ColorValuesChangedEvent and AccessibilitySettings.HighContrastChanged Event are no longer working.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Does this PR touch anything that might affect accessibility?

  • No

@jsuarezruiz
Copy link
Contributor Author

jsuarezruiz commented Jul 16, 2021

Windows
winui-appthemebinding

Use #1687 Thanks @Redth

@Redth Redth force-pushed the themes branch 2 times, most recently from 452a804 to c8fb317 Compare July 20, 2021 20:33
@Redth Redth merged commit b865406 into main Jul 20, 2021
@Redth Redth deleted the themes branch July 20, 2021 20:37
@samhouts samhouts added area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter platform/android 🤖 platform/iOS 🍎 platform/windows 🪟 labels Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! platform/android 🤖 platform/iOS 🍎 platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants