[ios] fix memory leaks in various controls #18434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: * `ActivityIndicator` * `BoxView` * `Polygon` * `Polyline` * `IndicatorView` Some of these were based on `PlatformGraphicsView`, which had a circular reference, for example: * `BoxView` -> `BoxViewHandler`/`PlatformGraphicsViewHandler` -> `PlatformGraphicsView` -> `BoxView` * It appears both `IDrawable` and `IGraphicsRenderer` values in `PlatformGraphicsView` were circular references. Various shapes were based on `PlatformGraphicsView`. We don't have the iOS memory analyzer running on `Microsoft.Maui.Graphics.dll` yet. Similarly: * `ActivityIndicator` -> `ActivityIndicatorHandler` -> `MauiActivityIndicator` -> `ActivityIndicator` * `IndicatorView` -> `IndicatorViewHandler` -> `MauiPageControl` -> `IndicatorView` *Open question*: Why didn't the analyzer catch the issues with `ActivityIndicator` and `IndicatorView`? Investigating why.
jonathanpeppers
added
memory-leak 💦
jonathanpeppers
commented
Oct 30, 2023
| IActivityIndicator? _virtualView; | ||
| readonly WeakReference<IActivityIndicator>? _virtualView; |
There was a problem hiding this comment.
Ok, it appears that interfaces slip through the analyzer:
Will fix in next version of analyzer.
jonathanpeppers
added a commit
to jonathanpeppers/memory-analyzers
that referenced
this pull request
Oct 30, 2023
Context: dotnet/maui#18434 (comment) This situation came up in .NET MAUI. You can create circular references with interfaces, as any `NSObject` can implement an interface. Warn about interfaces.
jonathanpeppers
added a commit
to jonathanpeppers/memory-analyzers
that referenced
this pull request
Oct 30, 2023
Context: dotnet/maui#18434 (comment) This situation came up in .NET MAUI. You can create circular references with interfaces, as any `NSObject` can implement an interface. Warn about interfaces.
PureWeen
approved these changes
Oct 30, 2023
21 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #18365
ActivityIndicatorBoxViewPolygonPolylineIndicatorViewSome of these were based on
PlatformGraphicsView, which had a circular reference, for example:BoxView->BoxViewHandler/PlatformGraphicsViewHandler->PlatformGraphicsView->BoxViewIt appears both
IDrawableandIGraphicsRenderervalues inPlatformGraphicsViewwere circular references.Various shapes were based on
PlatformGraphicsView. We don't have the iOS memory analyzer running onMicrosoft.Maui.Graphics.dllyet.Similarly:
ActivityIndicator->ActivityIndicatorHandler->MauiActivityIndicator->ActivityIndicatorIndicatorView->IndicatorViewHandler->MauiPageControl->IndicatorViewOpen question: Why didn't the analyzer catch the issues with
ActivityIndicatorandIndicatorView? Investigating why.