Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better exception for missing Maps on Windows #19046

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Add better exception for missing Maps on Windows #19046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9095c75
Add better exception for missing Maps on Windows
jfversluis Nov 27, 2023
bc5ba78
Update AppHostBuilderExtensions.cs
jfversluis Nov 27, 2023
63da38b
Stop UITests from crashing on Windows
jfversluis Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Controls/Maps/src/AppHostBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ public static IMauiHandlersCollection AddMauiMaps(this IMauiHandlersCollection h
handlersCollection.AddHandler<Pin, MapPinHandler>();
handlersCollection.AddHandler<MapElement, MapElementHandler>();
#endif

#if WINDOWS
throw new NotImplementedException(".NET MAUI Maps is currently not implemented for Windows. For more information, please see: https://aka.ms/maui-maps-no-windows");
mattleibow marked this conversation as resolved.
Show resolved Hide resolved
#else
return handlersCollection;
#endif
}
}
}
2 changes: 2 additions & 0 deletions src/Controls/samples/Controls.Sample.UITests/MauiProgram.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ public static class MauiProgram
public static MauiApp CreateMauiApp() =>
MauiApp
.CreateBuilder()
#if IOS || ANDROID
.UseMauiMaps()
#endif
.UseMauiApp<App>()
.Build();
}
Expand Down
Loading