Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the Locker GitHub action for locking closed/stale issues/PRs #19145

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jeffhandley
Copy link
Member

This migrates away from the FabricBot implementation of a scheduled search over closed issues and adopts the Locker GitHub action authored by the VS Code team.

The updated fabricbot.json was generated via dotnet/fabricbot-config#83. The workflow file was implemented and tested at https://github.com/dotnet/fabricbot-config/blob/main/.github/workflows/locker.yml.

Since this workflow uses the actions/checkout action, we need to ensure the following GitHub Actions settings are enabled:

  1. Allow enterprise, and select non-enterprise, actions and reusable workflows
  2. Allow actions created by GitHub

@jeffhandley jeffhandley requested a review from a team as a code owner December 1, 2023 01:10
@ghost ghost added the community ✨ Community Contribution label Dec 1, 2023
@ghost
Copy link

ghost commented Dec 1, 2023

Hey there @jeffhandley! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jeffhandley
Copy link
Member Author

FYI @wtgodbe

@Eilon Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Dec 2, 2023
@jeffhandley
Copy link
Member Author

After this PR is merged, there are only 2 other FabricBot features in use that need to be addressed (using 'noActivitySince' in an event filter, and 'addReactionToIssue') before we can apply the full transition away from it to the Policy Service bot.

@rmarinho
Copy link
Member

rmarinho commented Dec 4, 2023

I have checked and settings are enabled. Merging!

@rmarinho rmarinho merged commit babeeb2 into dotnet:main Dec 4, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
@samhouts samhouts added the fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions community ✨ Community Contribution fixed-in-8.0.6 Look for this fix in 8.0.6 SR1!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants