Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the powershell step #19258

Closed
wants to merge 1 commit into from
Closed

Do not use the powershell step #19258

wants to merge 1 commit into from

Conversation

mattleibow
Copy link
Member

Description of Change

Alternative to #19257

This is to address a reliability issue involving MAUI-DeviceTests. Tests run on Mac sporadically hang then fail (timeout) due to the following error:

The STDIO streams did not close within 10 seconds of the exit event from process '/usr/local/bin/pwsh'. This may indicate a child process inherited the STDIO streams and has not yet exited.

It seems that build.ps1 is getting executed as a powershell subprocess and in turn interfering with the IO stream for the pwsh step. As a mitigation, run build.ps1 under a bash step on Mac. This avoids flakiness and in turn avoids having to rerun failed tests.

@mattleibow mattleibow requested a review from a team as a code owner December 6, 2023 17:55
@mjbond-msft
Copy link
Contributor

mjbond-msft commented Dec 6, 2023

@mattleibow - I see the Windows device tests failed, which is a challenge I also faced. Perhaps they need to be run under powershell and not pwsh? but, on Mac definitely need to be run under pwsh

@rmarinho
Copy link
Member

Closing this one for now

@rmarinho rmarinho closed this Dec 11, 2023
@mattleibow mattleibow deleted the dev/pwsh branch December 13, 2023 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants