Reduce the complexity of the AttachAndRun code #19352
Conversation
Sometimes the Windows tests fail with no apparent reason, hopefully the slightly reduced complexit and more linear flow makes remote debugging easier. A specific change to first remove the window content before removing the view from the container might help.
| if (window.Content is not null) | ||
| throw new Exception("The window retrieved from the service is already attached to existing content"); | ||
|
|
||
| window.Content = new Grid |
There was a problem hiding this comment.
Do we want this to be a Grid? Would it make sense for this to be a ContentPanel or a a custom panel? That way we can call into the IView.Measure and IView.Arrange calls?
Which should let us remove calls like this
https://github.com/dotnet/maui/blob/main/src/Controls/tests/DeviceTests/Elements/Frame/FrameTests.cs#L438-L440
Which are now happening outside the natural layout cycle
I kicked off a lazy version of this idea here #19353 to see if it helps anything.
There was a problem hiding this comment.
I think I am using a double Grid because the first grid is the root, and then the second one keeps the view at the size it wants and centers. Maybe the inner grid should be the ContentPanel? I'll have a look when I wake up because all your points sound very valid but my brain says ZZZZZZ
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
Sometimes the Windows tests fail with no apparent reason, hopefully the slightly reduced complexit and more linear flow makes remote debugging easier. A specific change to first remove the window content before removing the view from the container might help.
Issues Fixed
Fixes #19015