Add ReceiveSms permission if it's declared in manifest #19660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14203 Removed the permission for `ReceiveSms` that was added by default if you tried to use the `Sms` permission on Android, which was only partially correct. We still want to add the `ReceiveSms` permission to the request if you have also defined it in your android manifest file, just like the other permissions optionally added. This fixes #19658
|
Missed #19659 does this already, closing mine in favour of theirs :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The PR #14203 Removed the permission for
ReceiveSmsthat was added by default if you tried to use theSmspermission on Android, which was only partially correct.We still want to add the
ReceiveSmspermission to the request if you have also defined it in your android manifest file, just like the other permissions optionally added.Issues Fixed
Fixes #19658