Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net9.0] Enable tizen #19679

Merged
merged 6 commits into from
Jan 11, 2024
Merged

[net9.0] Enable tizen #19679

merged 6 commits into from
Jan 11, 2024

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Jan 3, 2024

Description of Change

Enables Tizen on the net9 branch now that we have packages.

Issues Fixed

Fixes #19429

@rmarinho rmarinho requested a review from a team as a code owner January 3, 2024 17:50
@rmarinho rmarinho requested review from mattleibow, jsuarezruiz and jonathanpeppers and removed request for a team, mattleibow and jsuarezruiz January 3, 2024 17:50
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to make sure the package is on the dotnet-public feed:

error NU1101: Unable to find package Samsung.NET.Sdk.Tizen.Manifest-9.0.100-alpha.1. No packages exist with this id in source(s)

You can run the pipeline mentioned here:

@rmarinho
Copy link
Member Author

rmarinho commented Jan 3, 2024

Yeah I have mirror yesterday but it failed because of azure issues. I have re run, they should be there now.

@rmarinho
Copy link
Member Author

rmarinho commented Jan 3, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how green your CI is after the holiday (if the failures are OK or not).

But the actual code changes LGTM. 👍

@rmarinho rmarinho requested a review from a team as a code owner January 4, 2024 12:34
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="maui-application-id-placeholder" version="0.0.0" api-version="8" xmlns="http://tizen.org/ns/packages">
<manifest package="maui-application-id-placeholder" version="0.0.0" api-version="9" xmlns="http://tizen.org/ns/packages">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing templates.. tizen-manifest file is 7.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D:\a\_work\1\s\bin\dotnet\packs\Samsung.Tizen.Sdk\8.0.131\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : The api-version specified in tizen-manifest file is 7. [D:\a\_work\_temp\test-intg\Buildmauinet80ReleaseFalse\Buildmauinet80ReleaseFalse.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\bin\dotnet\packs\Samsung.Tizen.Sdk\8.0.131\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : Current target framework net8.0-tizen is not supported in this api-version. [D:\a\_work\_temp\test-intg\Buildmauinet80ReleaseFalse\Buildmauinet80ReleaseFalse.csproj::TargetFramework=net8.0-tizen]
    0 Warning(s)
    2 Error(s)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok the issue is 8.0.3 templates have api-version=7 we need to fix that on sr2

@rmarinho
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@JoonghyunCho
Copy link
Contributor

Looks like Tizen blocking issue is fixed?

@rmarinho rmarinho merged commit 18af5dd into net9.0 Jan 11, 2024
1 of 8 checks passed
@rmarinho rmarinho deleted the add-tizen-net9 branch January 11, 2024 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants