-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net9.0] Enable tizen #19679
[net9.0] Enable tizen #19679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably need to make sure the package is on the dotnet-public
feed:
error NU1101: Unable to find package Samsung.NET.Sdk.Tizen.Manifest-9.0.100-alpha.1. No packages exist with this id in source(s)
You can run the pipeline mentioned here:
Yeah I have mirror yesterday but it failed because of azure issues. I have re run, they should be there now. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how green your CI is after the holiday (if the failures are OK or not).
But the actual code changes LGTM. 👍
72d9b67
to
eb157a1
Compare
@@ -1,5 +1,5 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<manifest package="maui-application-id-placeholder" version="0.0.0" api-version="8" xmlns="http://tizen.org/ns/packages"> | |||
<manifest package="maui-application-id-placeholder" version="0.0.0" api-version="9" xmlns="http://tizen.org/ns/packages"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing templates.. tizen-manifest file is 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D:\a\_work\1\s\bin\dotnet\packs\Samsung.Tizen.Sdk\8.0.131\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : The api-version specified in tizen-manifest file is 7. [D:\a\_work\_temp\test-intg\Buildmauinet80ReleaseFalse\Buildmauinet80ReleaseFalse.csproj::TargetFramework=net8.0-tizen]
D:\a\_work\1\s\bin\dotnet\packs\Samsung.Tizen.Sdk\8.0.131\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : Current target framework net8.0-tizen is not supported in this api-version. [D:\a\_work\_temp\test-intg\Buildmauinet80ReleaseFalse\Buildmauinet80ReleaseFalse.csproj::TargetFramework=net8.0-tizen]
0 Warning(s)
2 Error(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok the issue is 8.0.3 templates have api-version=7 we need to fix that on sr2
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Looks like Tizen blocking issue is fixed? |
Description of Change
Enables Tizen on the net9 branch now that we have packages.
Issues Fixed
Fixes #19429