Fix SetProgressViewOffset on SwipeRefreshLayout

[PureWeen]

Description of Change

Alternate PR for
#17647

It looks like there are a few things going on here

1. it looks like there's a bug with the SwipeRefreshLayout. It's kind of odd because they fixed it two years ago, but it's not fixed in the latest androidx packages. If you look at the main branch they've added an else into the nestedscrollview code https://android-review.googlesource.com/c/platform/frameworks/support/+/1734993 which triggers a reset of the indicator so it hides when you scroll up. I tried a few paths to mimic what they are doing but I'm not sure a reliable way to do this. Also, I don't really like the way this looks. The indicator just kind of vanishes. The scaling generally seems like a nicer way to go.

2. I'm not sure why exactly, but, for whatever reason our RefreshView isn't clipping to bounds. If you use the SwipeRefreshLayout in a platform app you'll see the indicator goes outside the bounds of the refreshview so it hides itself out of view. My guess is that this is related to our layouts vs using androids in the box layouts.

3. Calling any of the SetProgress* APIs works around the original issue because calling any of those APIs sets the mUsingCustomStart private variable on the SwipeRefreshLayout which causes this path, so the visibility of the spinner will get set to Gone once you've scrolled all the way back to zero.

The size of the ToolBar is kind of irrelevant here. Like if you just call this
SetProgressViewOffset(false, ProgressViewStartOffset, ProgressViewEndOffset);

It works "fine"

if you call this
SetProgressViewOffset(false, 0, ProgressViewEndOffset);

It also works fine and then the refresh circle doesn't go above the RefreshView.

I'm not quite sure where y'all got 50 from, and what that's trying to accomplish?

If we want to somewhat replicate the values inside the SwipeRefreshLayout then I think we'd call it like this

SetProgressViewOffset(true, ProgressViewStartOffset, ProgressViewEndOffset - Math.Abs(ProgressViewStartOffset));

Which I just pulled from here

That causes the indicator when refreshing to land in the same spot. I like setting the scale to true. I think the non scaling version is odd, especially if there's a toolbar.

Also, I would call SetProgressViewOffset inside the ctor of SwipeRefreshLayout, that way if developers want to call SetProgressViewOffset themselves they don't have to figure out when we call it.

Issues Fixed

Fixes #17610

[jsuarezruiz]

If this was fixed two years ago, but later appears again in the latest AndroidX packages, should we detect the versions with problems and add conditional code only for certain API Levels?

[PureWeen]

The problem is, is that I have no idea what version of AndroidX this will actually be released on.

It's fixed on the main branch of their code but I don't really know how to track what version of AndoridX it will show up in.

[jsuarezruiz]

Nice description!. Very useful to understand what is happening.