Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 19647 #20127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix 19647 #20127

wants to merge 2 commits into from

Conversation

StephaneDelcroix
Copy link
Contributor

@StephaneDelcroix StephaneDelcroix commented Jan 24, 2024 •
edited
Loading

Description of Change

Warn on XAML and Bindings that can't be compiled
Compile Bindings used as properties (Setters, Triggers, MultiBindings)

Issues Fixed

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner January 24, 2024 09:13
@simonrozsival simonrozsival mentioned this pull request Jan 24, 2024
Merged
4 tasks
@StephaneDelcroix StephaneDelcroix force-pushed the fix_19647 branch 3 times, most recently from 293022c to 073e143 Compare January 24, 2024 16:22
@samhouts samhouts added the area-xaml XAML, CSS, Triggers, Behaviors label Jan 25, 2024
@StephaneDelcroix StephaneDelcroix mentioned this pull request Feb 1, 2024
Closed
@StephaneDelcroix StephaneDelcroix changed the base branch from main to net9.0 February 7, 2024 12:39
jonathanpeppers
jonathanpeppers previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good, just had the one question. 👍

(there is also a merge conflict)

...ontrols/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.targets Outdated
<Warning
Text="MauiXamlCValidateOnly set to true prevents trimming"
Code="XC0011"
Condition="'$(MauiXamlCValidateOnly)' == 'True'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be:

Suggested change
Condition="'$(MauiXamlCValidateOnly)' == 'True'" />
Condition="'$(_MauiXamlCValidateOnly)' == 'True'" />

Or is this trying to warn on Release mode only? So then if they set $(MauiXamlCValidateOnly) that would be the only way to get the warning?

@StephaneDelcroix StephaneDelcroix force-pushed the fix_19647 branch 2 times, most recently from 2aa2516 to 02372bd Compare February 14, 2024 13:41
@dotnet dotnet deleted a comment from rmarinho Feb 14, 2024
@StephaneDelcroix StephaneDelcroix force-pushed the fix_19647 branch 2 times, most recently from 6278b69 to 2ef2102 Compare February 14, 2024 14:31
@tranb3r
Copy link

tranb3r commented Mar 8, 2024

Is this going to be merged in SR3 ?

@dotnet dotnet deleted a comment from azure-pipelines bot Jun 13, 2024
@samhouts samhouts added the stale Indicates a stale issue/pr and will be closed soon label Aug 29, 2024
@StephaneDelcroix StephaneDelcroix force-pushed the fix_19647 branch 2 times, most recently from cbfd037 to ce71128 Compare September 27, 2024 15:07
@dotnet dotnet deleted a comment from rmarinho Sep 27, 2024
@dotnet dotnet deleted a comment from jsuarezruiz Sep 27, 2024
@dotnet dotnet deleted a comment from rmarinho Sep 27, 2024
@rmarinho rmarinho requested a review from a team as a code owner November 18, 2024 10:04
@rmarinho rmarinho changed the base branch from net9.0 to main November 18, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers left review comments

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors stale Indicates a stale issue/pr and will be closed soon
Projects
None yet
Milestone
No milestone
4 participants
@StephaneDelcroix @tranb3r @jonathanpeppers @samhouts