-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0.1xx-preview1] Revert "Dont build net8" #20286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d59c64.
rmarinho
requested review from
StephaneDelcroix and
tj-devel709
and removed request for
a team
February 1, 2024 12:13
samhouts
added
the
area-infrastructure
CI, Maestro / Coherency, upstream dependencies/versions
label
Feb 2, 2024
Update dotnet.cake Set env variables before build device tests Update DotnetInternal.cs Update dotnet.cake
rmarinho
force-pushed
the
bring-net8-back
branch
from
February 2, 2024 11:57
652ab8b
to
0fa8b78
Compare
jfversluis
approved these changes
Feb 2, 2024
jsuarezruiz
approved these changes
Feb 2, 2024
mattleibow
approved these changes
Feb 2, 2024
rmarinho
added a commit
that referenced
this pull request
Feb 5, 2024
* Update versions * Update Versions.props * Update versions * Update Versions.props * Update Versions.props * Fix ios versions * Update versions of Tizen * Update iOS * Update Version.Details.xml * Update Versions.props * Update versions again * Update sdk * Dont build net8 * Add loging * skip this one and see * [ci] Push artifacts for the sample tests (#20269) * [ci] Always publish the artifacts * remove verbosity * Enable stable branding * NativeAOT: Update NativeAOT integration tests to run with 9.0.1xx-preview1 (#20268) * Align expected NativeAOT build warning messages in integration tests * Do not treat NativeAOT build warnings as errors - introduced with dotnet/runtime#96567 * [release/9.0.1xx-preview1] Update versions (#20279) * Update versions * Ignore blazor tests on old webview * [release/9.0.1xx-preview1] Revert "Dont build net8" (#20286) * Revert "Dont build net8" This reverts commit 4d59c64. * Update versions * Update Compatibility.csproj * Update versions * Update dotnet.cake Update dotnet.cake Set env variables before build device tests Update DotnetInternal.cs Update dotnet.cake * Don't build template tests again --------- Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Ivan Povazan <55002338+ivanpovazan@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-infrastructure
CI, Maestro / Coherency, upstream dependencies/versions
fixed-in-9.0.100-preview.1.9973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4d59c64.
Description of Change
Now with sdk fixed we should be able to build net8 with preview1