[Trimming] Remove unnecessary regular expressions #21497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
approved these changes
Apr 9, 2024
Eilon
added
the
area-publishing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There are a few places where we use regular expressions, but we can achieve the same result fairly easily. By refactoring these few methods, we can remove the dependency on System.Text.RegularExpressions.dll completely and shaving off some dead weight. Consider the difference in .ipa size of
dotnet new mauibuilt with NativeAOT for iOS:There are still a few places where we use regular expressions (BlazorWebView, WebView, Windows-specific code) that we could investigate.
Issues Fixed
Contributes to #18658