Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Extend NativeAOT Templates tests to cover all supported platforms #21793

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ivanpovazan
Copy link
Member

Description of Change

This PR improves MAUI with NativeAOT test coverage by extending the Templates tests with cases for all supported platforms.

Additionally, as we reached 0 warnings for the template MAUI app and NativeAOT (via: #21050), I simplified the test cases.

NOTE: I did not remove the logic in src/TestUtils/src/Microsoft.Maui.IntegrationTests/Utilities/BuildWarningsUtilities.cs intentionally, as we might want to use it for testing builds of apps which still have trim/AOT warnings.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I just reran some of the failures to see if it will be more green.

I didn't see a failure related to the changed tests, though.

@rmarinho rmarinho merged commit d22dece into dotnet:net9.0 Apr 15, 2024
48 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants