[Trimming] Enable analyzers in Controls.Xaml #21927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
reviewed
Apr 19, 2024
MartyIX
reviewed
Apr 19, 2024
This reverts commit 46ec439.
…nalyzers-controls-xaml
Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com>
…ival/maui into enable-analyzers-controls-xaml
simonrozsival
commented
Apr 25, 2024
| @@ -13,6 +14,7 @@ namespace Microsoft.Maui.Controls.Xaml | |||
| typeof(IValueConverterProvider), | |||
| typeof(IXmlLineInfoProvider), | |||
| typeof(IConverterOptions)])] | |||
| [RequiresUnreferencedCode("The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead.")] | |||
There was a problem hiding this comment.
@jonathanpeppers this is the case I'm most worried about of these extensions. The {OnIdiom ...} cannot be simplified at compile time and I don't think we can really make it trimming-friendly because of Activator.CreateInstance(propertyType) which we call for value types.
There was a problem hiding this comment.
I wonder if XamlC could transform OnIdiomExtension into OnIdiom<T> when it can infer T from the values passed to it 🤔 It might be worth trying.
There was a problem hiding this comment.
Yeah, I think we could file an issue to fix {OnIdiom} in the future.
This PR makes good progress, so doesn't have to fix it here yet.
jonathanpeppers
approved these changes
Apr 30, 2024
Eilon
added
the
area-infrastructure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR enables analzyers in Controls.Xaml.csproj.
Almost all XAML runtime parsing code is marked with RUC and RDC. The
TryGetPropertyNamemethod was moved outside ofApplyPropertiesVisitorso that it can be called without producing a warning.I introduced a new feature switch- EDIT: the feature switch wasn't needed after allAreNonCompiledBindingsInXamlSupportedand I'm thinking if it is the right way to go about it. I'm not very happy that it is necessary inBindingExtension.csand I'm thinking if maybe we could transformBindingExtensionintoTypedBindingExtensionin XamlC to split those two codepaths. This is the main reason why I'm opening this PR as a Draft for now./cc @StephaneDelcroix
Issues Fixed
Contributes to #18658