[XC] Compile TemplateBindingExtension #22008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
commented
May 2, 2024
| ) | ||
| foreach (var instruction in CompileBindingPath(node, context, vardefref.VariableDefinition)) | ||
| yield return instruction; | ||
| if (bpRef is not null) // do not compile bindings if we're not gonna SetBinding |
There was a problem hiding this comment.
I hope we can remove this condition in #22023
|
Could you rebase to fix the conflict? Thnx! |
simonrozsival
force-pushed
the
compile-template-binding
branch
from
240f0a3 to
9350443
Compare
jsuarezruiz
approved these changes
May 22, 2024
StephaneDelcroix
approved these changes
May 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
{TemplateBinding ...}is "just" a shorthand for{Binding RelativeSource={RelativeSource TemplatedParent}, Path = ...}. It should be possible to use{TemplateBinding}with NativeAOT as well and so it should be possible to compile it.Issues Fixed
Contributes to #18658